Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for minor header bug #3063

Merged

Conversation

Tiny-DM
Copy link

@Tiny-DM Tiny-DM commented Nov 23, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

the variable for the title was a private variable, so the hint actually calls the stringtable
decreased the time to wait to match a bit closer with when the animation is finished

Please specify which Issue this PR Resolves.

closes #3050

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

_titleStr is a private variable, so the replacement should solve the header issue. 3 seconds have been taken off the time to more closely match the actual time for the animation to finish
@Bob-Murphy
Copy link

If you check line 24, this private variable is done so you don't have to put the localize ..... in every hint title when all hints have the same title.
It also works for all the other instances (this is used in 56 different files) so there must be a different reason.

@Tiny-DM
Copy link
Author

Tiny-DM commented Nov 23, 2023

Unfortunately, I don't have the intelligence to know why exactly, but this is what fixed it. My assumption is because the variable is nested inside an action and doesn't have access, because otherwise it should be fine

@jaj22
Copy link

jaj22 commented Nov 23, 2023

The fix is correct. The reason is that it's used in an addAction here, so it's accessed in a completely different scope from where the local variable is defined. Event handlers are similar.

This isn't the only case where pulling out _titleStr breaks. There's a similar issue in the towing code. Maybe others.

@jaj22 jaj22 added the Bug Something isn't working label Nov 23, 2023
@jaj22 jaj22 added this to the 3.4.1 milestone Nov 23, 2023
@Tiny-DM Tiny-DM closed this Nov 23, 2023
@Tiny-DM Tiny-DM reopened this Nov 23, 2023
@Bob-Murphy
Copy link

Could you please fix similar issues in the following files and give the PR a title change?
Thank you

  • core\Scripts\fn_advancedTowingInit.sqf
  • core\functions\REINF\fn_controlHCsquad.sqf
  • core\functions\REINF\fn_controlunit.sqf

@Tiny-DM Tiny-DM changed the title Fix for aborting outpost capture Fix for minor header bug Nov 23, 2023
@Tiny-DM
Copy link
Author

Tiny-DM commented Nov 23, 2023

Forcing me to do the most basic shit....
done and tested @Bob-Murphy

also worth noting that the controlling squads pop up is bugged anyway but I fixed the part I was supposed to and will look at the rest

@Bob-Murphy Bob-Murphy merged commit ef1b91d into official-antistasi-community:unstable Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Aborting Outpost Capture has missing title
3 participants