-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for minor header bug #3063
Fix for minor header bug #3063
Conversation
_titleStr is a private variable, so the replacement should solve the header issue. 3 seconds have been taken off the time to more closely match the actual time for the animation to finish
If you check line 24, this private variable is done so you don't have to put the |
Unfortunately, I don't have the intelligence to know why exactly, but this is what fixed it. My assumption is because the variable is nested inside an action and doesn't have access, because otherwise it should be fine |
The fix is correct. The reason is that it's used in an addAction here, so it's accessed in a completely different scope from where the local variable is defined. Event handlers are similar. This isn't the only case where pulling out _titleStr breaks. There's a similar issue in the towing code. Maybe others. |
Could you please fix similar issues in the following files and give the PR a title change?
|
Forcing me to do the most basic shit.... also worth noting that the controlling squads pop up is bugged anyway but I fixed the part I was supposed to and will look at the rest |
What type of PR is this.
What have you changed and why?
the variable for the title was a private variable, so the hint actually calls the stringtable
decreased the time to wait to match a bit closer with when the animation is finished
Please specify which Issue this PR Resolves.
closes #3050
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes: